Skip to content

Migrate calendar events#5040

Open
yujonglee wants to merge 2 commits intomainfrom
migrate-calendar-events
Open

Migrate calendar events#5040
yujonglee wants to merge 2 commits intomainfrom
migrate-calendar-events

Conversation

@yujonglee
Copy link
Copy Markdown
Contributor

No description provided.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for hyprnote canceled.

Name Link
🔨 Latest commit 6b54113
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/69de2401bf11820008c4cc40

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for char-cli-web canceled.

Name Link
🔨 Latest commit 6b54113
🔍 Latest deploy log https://app.netlify.com/projects/char-cli-web/deploys/69de24019ded640008ca4a4a

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 14, 2026

Deploy Preview for unsigned-char ready!

Name Link
🔨 Latest commit 6b54113
🔍 Latest deploy log https://app.netlify.com/projects/unsigned-char/deploys/69de2401a7a3ba0008051b12
😎 Deploy Preview https://deploy-preview-5040--unsigned-char.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6b54113. Configure here.

participantsJson:
event.participants.length > 0
? JSON.stringify(event.participants)
: undefined,
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double JSON stringification corrupts participantsJson in database

High Severity

The participantsJson column is defined in the Drizzle schema with text("participants_json", { mode: "json" }), which means Drizzle automatically calls JSON.stringify() on inserts/updates. However, executeForEventsSync pre-stringifies with JSON.stringify(event.participants) before passing to updateEvent/insertEvent, causing double-encoding. The stored value becomes an escaped JSON string (e.g., "[{\"name\":\"John\"}]") instead of a proper JSON array. The existing templates code in this codebase correctly passes raw objects to JSON-mode columns, confirming the expected pattern.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6b54113. Configure here.

Comment thread crates/db-app/src/lib.rs
"activity_screenshots",
"daily_notes",
"daily_summaries",
"prompt_overrides",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration test missing new calendars and events tables

Medium Severity

The migration_creates_tables test asserts an expected table list that doesn't include calendars or events, even though the new migration 20260414120000_calendars_events.sql creates both tables. The test queries sqlite_master after running all migrations, so these tables will exist, causing the assertion to fail.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 6b54113. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant